Skip to content

fix(button): added logical start/end vals to iconPosition#9611

Merged
tlabaj merged 5 commits into
patternfly:mainfrom
mcoker:issue-9589
Sep 12, 2023
Merged

fix(button): added logical start/end vals to iconPosition#9611
tlabaj merged 5 commits into
patternfly:mainfrom
mcoker:issue-9589

Conversation

@mcoker

@mcoker mcoker commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

fixes #9589

@patternfly-build

patternfly-build commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

@mcoker mcoker changed the title fix(button): added logical start/end vals to iconposition fix(button): added logical start/end vals to iconPosition Sep 12, 2023

@tlabaj tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 50b1bc3 into patternfly:main Sep 12, 2023
@patternfly-build

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-code-editor@5.1.1-prerelease.9
  • @patternfly/react-core@5.1.1-prerelease.9
  • @patternfly/react-docs@6.1.1-prerelease.10
  • demo-app-ts@5.1.1-prerelease.8
  • @patternfly/react-table@5.1.1-prerelease.9

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button - RTL support

4 participants